Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to remove any attachment/embed #147

Closed
wneessen opened this issue Oct 19, 2023 · 4 comments · Fixed by #149
Closed

Add method to remove any attachment/embed #147

wneessen opened this issue Oct 19, 2023 · 4 comments · Fixed by #149
Assignees
@wneessen @leahoop
Labels
enhancement New feature or request hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest

Comments

@wneessen
Copy link
Owner

Is your feature request related to a problem? Please describe.

Based on this issue it would be nice to have a method that removes all attachments/embeds that are currently attached to a Msg. This should be a simple change.

Describe the solution you'd like

I am thinking about three seperate methods:

  • Msg.UnsetAllAttachments(): That removes all currently assigned attachments
  • Msg.UnsetAllEmbeds(): That removes all currently assigned embeds
  • Msg.UnsetAllParts(): That removes all currently assigned attachments and embeds

Describe alternatives you've considered

No response

Additional context

No response
@wneessen wneessen added enhancement New feature or request hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest labels Oct 19, 2023
@wneessen wneessen self-assigned this Oct 19, 2023
@leahoop
Copy link
Contributor

leahoop commented Oct 19, 2023

Have these methods been assigned yet? If not maybe I can a try

@wneessen
Copy link
Owner Author

@leahoop Feel free to give it a try! Appreciate the initiative!

@leahoop
Copy link
Contributor

leahoop commented Oct 19, 2023

thanks, it's my pleasure

leahoop added a commit to leahoop/go-mail that referenced this issue Oct 20, 2023
@leahoop
wneessen#147 add remove attachments and embeds methods
3c2c106
@leahoop leahoop mentioned this issue Oct 20, 2023
Merged
wneessen added a commit that referenced this issue Oct 20, 2023
@wneessen
Merge pull request #148 from leahoop/147_remove_attachments_and_embeds
a4379a5 
#147 add remove attachments and embeds methods
@wneessen
Copy link
Owner Author

Merged to main.

@wneessen wneessen linked a pull request Oct 20, 2023 that will close this issue
Feature/147 add method to remove any attachmentembed #149
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wneessen wneessen

@leahoop leahoop

Labels
enhancement New feature or request hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/147 add method to remove any attachmentembed wneessen/go-mail
2 participants
@wneessen @leahoop