Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Global Replay (#143) #144

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add Global Replay (#143) #144

wants to merge 6 commits into from

Conversation

tomkralidis
Copy link
Collaborator

@tomkralidis tomkralidis commented Jun 3, 2024 •
edited
Loading

Fixes #143

@tomkralidis tomkralidis mentioned this pull request Jun 3, 2024
Open
@tomkralidis tomkralidis added this to the FT2024-2 milestone Jun 3, 2024
golfvert
golfvert reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@golfvert golfvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, points to discuss.
I don't understand how users will get the data.
On the HTTPS stream ?

guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
guide/sections/part2/global-services.adoc Show resolved Hide resolved
guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
guide/sections/part2/global-services.adoc Outdated Show resolved Hide resolved
@tomkralidis
Copy link
Collaborator Author

@golfvert thanks for the feedback. Updates pushed. Let me know if there are additional issues.

@tomkralidis tomkralidis requested a review from golfvert June 5, 2024 19:08
@amilan17 amilan17 removed this from the FT2024-2 milestone Jul 15, 2024
amilan17
amilan17 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely editorial revisions suggested.

amilan17
amilan17 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@amilan17 amilan17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed "the" from wis2-grep.

@tomkralidis tomkralidis force-pushed the issue-143 branch 2 times, most recently from 144b16a to eedd477 Compare August 5, 2024 10:35
golfvert
golfvert reviewed Aug 5, 2024
View reviewed changes
guide/sections/part2/global-services.adoc Outdated
* Global Replay instances operate independently of each other; each Global Replay instance will hold notification messages according to the required retention period. Global Replays do not need to synchronise between themselves.
* A Global Replay is populated with notification messages from a Global Broker instance.
* A Global Replay should connect and subscribe to more than one Global Broker instance to ensure that no messages are lost in the event of a Global Broker failure. A Global Replay instance will discard duplicate messages as needed.
* A Global Replay will validate notification messages against the WIS Notification Message (WNM). Valid WIS Notification Messages will be ingested into the index. Invalid or malformed notification messages will be discarded.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real need to check. No problem though, to do it again.

Copy link
Collaborator Author

@tomkralidis tomkralidis Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to can

@golfvert
Copy link
Collaborator

golfvert commented Aug 5, 2024

The usable API is not defined. Is that on purpose ? We may have different Global replay providing different API. Is that what we want ?

@tomkralidis
Copy link
Collaborator Author

The usable API is not defined. Is that on purpose ? We may have different Global replay providing different API. Is that what we want ?

In GRep Technical Considerations, we define the API per:

* The Global Replay implements the OGC API – Features – Part 1: Core standardfootnote:[https://docs.ogc.org/is/17-069r4/17-069r4.html], adhering to the following conformance classes and their dependencies:
** Core
** GeoJSON
* The Global Replay implements the OGC API – Processes - Part 1: Core standardfootnote:[https://docs.ogc.org/is/18-062r2/18-062r2.html], adhering to the following conformance classes and their dependencies:
** Core
** OGC Process Description
** JSON

@amilan17
Copy link
Member

@golfvert @tomkralidis Is this issue ready for FT2024-2 or does it need more conversation/review? I'm finalizing all proposals this week.

@golfvert
Copy link
Collaborator

It is too soon to be in the FT. We haven't had a proper discussion in the team.
I also don't think it should be in the guide anyhow.
We discussed this with Tom. I don't think we want additional (and useful) services such as GRep in the guide. I guess and hope we will have other similar services, and I don't think we want the guide to be "bloated" with everything.
We have to find the right home to document this. It could be in the cookbook or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golfvert golfvert golfvert left review comments

@amilan17 amilan17 amilan17 requested changes

@6a6d74 6a6d74 Awaiting requested review from 6a6d74

@hhaddouch hhaddouch Awaiting requested review from hhaddouch

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Global Replay Service
3 participants
@tomkralidis @golfvert @amilan17