Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and fix issue with API returning empty array #678

Closed
wants to merge 3 commits into from

Conversation

sudheer-rk
Copy link
Contributor

The TfWM API is returning an empty array void of tram stop details:

#655

@sudheer-rk sudheer-rk added the bug Something isn't working label Nov 3, 2022
@sudheer-rk sudheer-rk self-assigned this Nov 3, 2022
@gitguardian
Copy link

gitguardian bot commented Nov 3, 2022

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
1065342 Generic High Entropy Secret 10b2183 .env.development View secret
1065341 Generic High Entropy Secret 10b2183 .env.production View secret
1065342 Generic High Entropy Secret 10b2183 netlify.toml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sudheer-rk sudheer-rk changed the base branch from master to develop November 3, 2022 15:00
@sudheer-rk sudheer-rk closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant