Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scene] Add blur parameters to rects #78

Open
ErikReider opened this issue Nov 15, 2024 · 4 comments
Open

[Scene] Add blur parameters to rects #78

ErikReider opened this issue Nov 15, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ErikReider
Copy link
Member

No description provided.

@ErikReider ErikReider added the enhancement New feature or request label Nov 15, 2024
@WillPower3309
Copy link
Member

WillPower3309 commented Nov 16, 2024

Hmm, it's really too bad blur is reliant on the texture discarding :/ if blur was a node we wouldn't need this! Maybe we can separate blur into a node and get the tex stencil of the buffer above it similar to what we do for the borders and shadows

@WillPower3309
Copy link
Member

Oops deleted my comment accidentally, tldr was we should make blur a node and then get the tex stencil similar to how we get the rect / buffer dimensions of the above node for shadows and borders

@WillPower3309
Copy link
Member

Then we not only simplify our rendering logic but also get this for free!

@WillPower3309
Copy link
Member

Also, we don't need this for swayfx compat. We can think about moving to a blur node after we rebase swayfx :)

@WillPower3309 WillPower3309 added this to the scenefx 1.0 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants