Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for deep copy of status matrix #72

Closed
2 of 6 tasks
shikokuchuo opened this issue May 9, 2023 · 1 comment
Closed
2 of 6 tasks

No need for deep copy of status matrix #72

shikokuchuo opened this issue May 9, 2023 · 1 comment
Assignees

Comments

@shikokuchuo
Copy link
Contributor

Prework

Description

I just saw this in your recent commit so thought I should mention that there is no need for rlang / full duplicate. I am sure whatever issue it was for has been solved by other means. Also as of mirai 0.8.4, the daemons() status matrix is constructed on the client side - it is not sent as an object from dispatcher so there is no possibility of it being anything other than a simple matrix.

rlang::duplicate(
        mirai::daemons(.compute = self$name)$daemons,
        shallow = FALSE
      )
@wlandau
Copy link
Owner

wlandau commented May 9, 2023

Thanks for the FYI, happy to remove calls to rlang::duplicate().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants