Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to undocumented compatibility interfaces in {mirai} #66

Closed
2 of 6 tasks
shikokuchuo opened this issue Apr 17, 2023 · 1 comment
Closed
2 of 6 tasks

Comments

@shikokuchuo
Copy link
Contributor

Prework

Description

This is mostly already done. {mirai} 0.8.3 currently has 2 compatibility fixes for crew 0.0.5 which I would like to do away with for future releases.

  1. Re-creates the daemons status matrix on the fly with the previous headings. I could not find any reference to the old headers searching the code on Github so all good here.
  2. 'cleanup' argument to server() still accepts TRUE/FALSE, should always be an integer value going forward. There is one remaining reference I found in a test, should just be changed to 0L:
    settings <- list(url = url, maxtasks = 1L, cleanup = FALSE)

Thanks!

@wlandau
Copy link
Owner

wlandau commented Apr 17, 2023

Thanks for the FYI. Yes, for (1), crew assumes e.g. instance instead of instance # and online instead of status_online. And for (2), 96f5d15 removes the remaining reference to a logical cleanup arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants