Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All locale data included in bundle #232

Open
MaximeCheramy opened this issue Jul 3, 2023 · 1 comment · May be fixed by #233
Open

All locale data included in bundle #232

MaximeCheramy opened this issue Jul 3, 2023 · 1 comment · May be fixed by #233

Comments

@MaximeCheramy
Copy link

Since intl-relativetimeformat 6.0, the locales are no longer located in the dist subfolder (https://github.com/formatjs/formatjs/blob/main/packages/intl-relativetimeformat/CHANGELOG.md#600-2020-07-03). As a consequence, this line has no effect:

https://github.com/wiziple/gatsby-plugin-intl/blob/master/src/gatsby-node.js#L29

new webpack.ContextReplacementPlugin(
        /@formatjs[/\\]intl-relativetimeformat[/\\]dist[/\\]locale-data$/,
        regex
      )

The fix is probably to just remove the dist[/\\] part but I haven't tried.
@MaximeCheramy MaximeCheramy changed the title All locales included in bundle All locale date included in bundle Jul 3, 2023
@MaximeCheramy MaximeCheramy changed the title All locale date included in bundle All locale data included in bundle Jul 3, 2023
@MaximeCheramy MaximeCheramy linked a pull request Jul 5, 2023 that will close this issue
Open
@LukasAV
Copy link

LukasAV commented Jul 31, 2024

I was inspecting my bundle size and noticed the same thing. @wiziple any update here why the PR could not be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix formatjs's paths to local-data to reduce bundle size MaximeCheramy/gatsby-plugin-intl
2 participants
@MaximeCheramy @LukasAV