Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[th/print-results-multiple] print_results: support printing multiple results #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thom311
Copy link
Collaborator

@thom311 thom311 commented Dec 10, 2024

Since "config.yaml" can contain multiple tests and "tft.py" can write multiple result files, so also "print_results.py" should handle multiple files.

That way,

./tft.py -o ft-logs/result- config.yaml
./print_results.py ft-logs/result-*.json

works to check all result files, regardless how many tests are defined in config.yaml.

Since "config.yaml" can contain multiple tests and "tft.py" can
write multiple result files, so also "print_results.py" should
handle multiple files.

That way,

  ./tft.py -o ft-logs/result- config.yaml
  ./print_results.py ft-logs/result-*.json

works to check all result files, regardless how many tests are defined
in config.yaml.
@thom311 thom311 self-assigned this Dec 10, 2024
@thom311
Copy link
Collaborator Author

thom311 commented Dec 10, 2024

this is done because in https://gitlab.cee.redhat.com/ccit/jenkins-csb-customers/nst-casc-net-hw-ci/-/blob/5e59d37e2773b6d28ee180490aadf900eb2cbaed/scripts/ovn-traffic-flow/traffic-flow-run-test.jenkinsfile#L59 we do:

./print_results.py $(ls ft-logs/*-RESULTS)

previously, that only works because the used config.yaml happens to only contain one test. This line should always work correctly, regardless how many test results are created by tft.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant