Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate uninstall rollback does not rollback the deletion of the certifcate #3976

Open
wixbot opened this issue Apr 18, 2013 · 5 comments · May be fixed by wixtoolset/wix3#546
Open

Certificate uninstall rollback does not rollback the deletion of the certifcate #3976

wixbot opened this issue Apr 18, 2013 · 5 comments · May be fixed by wixtoolset/wix3#546
Labels
Milestone

Comments

@wixbot
Copy link

wixbot commented Apr 18, 2013

When canceling an uninstallation of a package that installs certificates the certificates are still deleted. I expect that the rollback action should re-install the certificates if uninstallation is canceled/fails.

Looking at the code it seems that the FindExistingCertificate function in scacert.cpp is not using the suffix created when installing the certificates (_wix_certX) when comparing against the installed certificates. Therefore not finding that the certificate is installed and not scheduling a rollback custom action.

This can be tested by having the in the package (and also some certificate
<iis:Certificate Id='someId' Name='someName'
StoreName='root' StoreLocation='localMachine'
BinaryKey='someBinary
Overwrite='yes'
Request='no' /> )
and using the command line:

msiexec /lv* setup.log /x msipackage.msi WIXFAILWHENDEFERRED=1

Originally opened by henrikjohansson from http://sourceforge.net/p/wix/bugs/3273/

@wixbot
Copy link
Author

wixbot commented Apr 18, 2013

It seems my xml-snippets were eaten by the formatter. What I meant to write was that I used WixFailWhenDeferred to test this. And when uninstalling specifying WIXFAILWHENDEFERRED=1

@wixbot
Copy link
Author

wixbot commented Oct 8, 2013

Originally changed by barnson
Release changed from v3.8 to v3.x

@wixbot wixbot added the bug label Dec 20, 2015
@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@Thaldin
Copy link

Thaldin commented Jan 9, 2018

Any timeline on this? We have run into this issue as well.

@robmen
Copy link
Member

robmen commented Jan 9, 2018

This issue is open and unassigned. That means it is waiting for someone to investigate the root problem, discuss possible solutions to that problem then implement the decided solution.

If you are interested in doing so yourself, our developer documentation provides a great checklist for getting started.

If you are not interested then you are waiting for someone else to become interested. If this issue has been open for a long time then there probably isn't much interest in this particular issue. In that case, you'll want to consider how to motivate others to fix it for you. This is a pretty good list of support options.

@IlyaSamokhin97
Copy link

I want to work on it

@IlyaSamokhin97 IlyaSamokhin97 linked a pull request Sep 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants