Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WcaGetRecordFormattedString to get firewall rule description #445

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

chrisbednarski
Copy link
Contributor

@chrisbednarski chrisbednarski commented Aug 20, 2023

  • The column definition for the Description says it's a formatted string, but it was retrieved as a plain string
  • fixed a few typos in the comments
  • added missing RemoteAddresses and LocalAddresses assert
  • added integration test for using formatted properties

@chrisbednarski chrisbednarski force-pushed the feat/formatted-properties branch 2 times, most recently from f710288 to 99fdd06 Compare August 21, 2023 01:51
@chrisbednarski
Copy link
Contributor Author

I've updated the failing test to use Environment.GetEnvironmentVariable

And AWS getting in my way, as per usual. Added RemoteAddresses to the firewall rule unique check.

@barnson barnson merged commit 537e79d into wixtoolset:develop Aug 24, 2023
3 checks passed
@barnson
Copy link
Member

barnson commented Aug 24, 2023

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
@chrisbednarski chrisbednarski deleted the feat/formatted-properties branch August 24, 2023 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants