Automatically add logging flag for any burn ExePackage, BundlePackage, and related bundles #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nirbar is this a proposed fix for wixtoolset issue 5220? If so can you put To make it clear the intent is to fix the issue. It also automatically closes the issue. Putting the number in the title does not tie the issue to this PR and confuses us. :) |
nirbar
force-pushed
the
develop-5220-related-bundle-log
branch
from
23d6f73
to
375c94d
Compare
nirbar
changed the title
…burn ExePackage, BundlePackage, and related bundles
barnson
force-pushed
the
develop-5220-related-bundle-log
branch
from
375c94d
to
28f954d
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wixtoolset/issues#5220: Automatically add logging flag for any burn ExePackage, BundlePackage, and related bundles