From eefb3d63313ec7370d238e74f37de156f7c62412 Mon Sep 17 00:00:00 2001 From: Bob Arnson Date: Tue, 3 Sep 2024 14:25:04 -0400 Subject: [PATCH] Fix crash with use of File/@PatchGroup. --- .../Bind/UpdateMediaSequencesCommand.cs | 2 +- .../TestData/PatchFromWixlib/Package.wxs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs index e0ed56b10..8cf2df3a6 100644 --- a/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs +++ b/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs @@ -60,7 +60,7 @@ public void Execute() if (facade.PatchGroup.HasValue) { - if (patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup)) + if (!patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup)) { patchGroup = new List(); patchGroups.Add(facade.PatchGroup.Value, patchGroup); diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs index 5cab1dbd7..1e2efb40f 100644 --- a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs +++ b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs @@ -17,7 +17,7 @@ - +