refactor(core): prepare process AST mods for move to transform #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new feature hook `prepareAST` to remove a node or do custom mods - call `prepareAST` on every node at the end of analyze - move `imports`, `namespace`, and `vars` to `prepareAST` - `:vars` require a bailout when running on props, since without eager removal `URLs` are being collected twice AND custom property can be defined within a var value (not the currect behavior)
idoros
added
core
- remove temp `stubs` - custom selector is anlyzed with the statement - remove `@custom-selector` and extends rules at the end of the process - keep track of if custom selector is scoped and use flag to report unscoped selectors that use the custom selector
- cleanup `toRemove` code in feature and processor
- deprecate annotation on `meta.scopes` - refactor initial `st-scope` feature to manage `analyze/prepareAST` from processor
barak007
reviewed
May 8, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the AST modifications that occur in the processor to prepare them to be moved to the transformer
prepareAST- new feature hook called on every node at the end of the analyze process@namespace:vars@st-import/:import@st-global-custom-property@custom-selector@st-scope