Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): css-custom-property feature overall #2216

Merged
merged 23 commits into from
Jan 23, 2022

Commits on Dec 21, 2021

  1. Configuration menu
    Copy the full SHA
    5553e90 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Merge branch 'master' of github.com:wix/stylable into ido/css-custom-…

    …property-feature-extraction
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e7f06c0 View commit details
    Browse the repository at this point in the history
  2. chore: init css-custom-property feature

    - feature file `/features/css-custom-property.ts`
    - moved `CSSVarSymbol` symbol
    - export empty diagnostics and hooks
    - register to stylable meta class
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c249470 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    498c3a8 View commit details
    Browse the repository at this point in the history
  4. refactor: processor css-custom-property feature extract

    - moved all code related to feature file
    - new `analyzeDeclaration` feature hook
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    3067265 View commit details
    Browse the repository at this point in the history
  5. refactor: extract helpers

    - `isCSSVarProp` from `stylable-utils` to `helpers/css-custom-property`
    - `validateAllowedNodesUntil` from `stylable-value-parser` to `helpers/value`
    - `globalValue` from `utils` to `helpers/global`
    - deprecate `paramMapping` constant export
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4deced9 View commit details
    Browse the repository at this point in the history
  6. refactor: move more code from processor to feature

    - analyze `@st-global-custom-property` to feature
    - add `toRemove` api to `analyzeAtRule` feature until `rawAst` is immutable
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    b5ddb8f View commit details
    Browse the repository at this point in the history
  7. refactor: transformer css-custom-property feature extract

    - `transformResolve`
    - `transformAtRule`
    - `transformJSExports`
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e088a45 View commit details
    Browse the repository at this point in the history
  8. refactor: move transform value var() to feature

    - `transformDeclarationValue` new hook
    - transform `var()` extract from `functions` to feaure
    - `stringifyFunction` from `functions` to `helpers/value`
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    648230b View commit details
    Browse the repository at this point in the history
  9. refactor: --X: declaration prop transform to feature

    - `transformDeclaration` - move `--X: ;` namespace to feature
    - `getScopedCSSVar` from `transformer` to `helpers/css-custom-property`
    - deprecate `transformer.getScopedCSSVar()`
    idoros committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    7ea1051 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Merge branch 'master' of github.com:wix/stylable into ido/css-custom-…

    …property-feature-extraction
    idoros committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    e38fe8a View commit details
    Browse the repository at this point in the history
  2. test: move tests from css-vars.spec to feature spec

    - refactored to new format with inline tests and `testStylableCore`
    - add internal `CSSCustomProperty.get(symbolName)`
    idoros committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    f596744 View commit details
    Browse the repository at this point in the history
  3. test: move more tests to feature spec

    - `exports.spec` css custom property tests
    - test for resolving mixed-in property override
    - moved skipped escape test
    idoros committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    f61a55e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Configuration menu
    Copy the full SHA
    495482f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Configuration menu
    Copy the full SHA
    f7a04f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Configuration menu
    Copy the full SHA
    ea9d2f9 View commit details
    Browse the repository at this point in the history
  2. refactor: reorder and cleanups

    - add `alias` field to `CSSVarSymbol` to point to imported symbol
    - implemented suppurt for aliased in resolver and completion-provider
    - register `--` prefixed imports as aliased custom property symbols
    - sort conflicted symbol definitions from import, `@property`, and `@st-custom-global-property`
    idoros committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    67ea1b5 View commit details
    Browse the repository at this point in the history
  3. chore: deprecate meta.cssVars

    idoros committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    7f120e8 View commit details
    Browse the repository at this point in the history
  4. test: fix scopeCSSVar unit test

    - import path and file name didn't match
    idoros committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8b5eda4 View commit details
    Browse the repository at this point in the history
  5. fix: empty var() crush

    - keep `var()` untransformed
    - report empty prop name diagnostic
    idoros committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8d7113a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a235be6 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. chore: fix review comments

    idoros committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    02760af View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:wix/stylable into ido/css-custom-…

    …property-feature-extraction
    idoros committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    df4946e View commit details
    Browse the repository at this point in the history