Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Show LightBox Equivalent #4629

Closed
RomualdPercereau opened this issue Jan 23, 2019 · 1 comment
Closed

[v2] Show LightBox Equivalent #4629

RomualdPercereau opened this issue Jan 23, 2019 · 1 comment

Comments

@RomualdPercereau
Copy link
Contributor

Issue Description

There is actually no equivalent of showLightBox in v2
The new version introduce 2 features : showModal and showOverlay.

ShowModal

This is supposed to push a new full screen controller, which works like Navigation.push

ShowOverlay

There is no animation, no background management, interceptTouchOutside doesn't work as expected (#4622)

You can bullshit to have something like the previous showLightBox : #4060.

Alternatives

The cleaner way to display a modal on v2 is probably the official way: https://facebook.github.io/react-native/docs/modal

Any Plans ?

Any plans to replace this feature with should be on the native side and done by the navigator?

Environment

  • React Native Navigation version: 2.7.1
  • React Native version: 0.57
  • Platform(s) (iOS, Android, or both?): Both
  • Device info (Simulator/Device? OS version? Debug/Release?): Alls
@guyca
Copy link
Collaborator

guyca commented Jan 24, 2019

Bullshitting as shown in #4060 seems like a great idea!
lightbox isn't implemented in v2 because it's not a native component and can be easily implemented (bullshit as you describe it) using Overlay.
Want to handle touch events outside of the actual lightbox? use TouchableWithoutFeedback, don't want to repeat yourself? open source your bullshit.

good luck and happy bullshitting.

@guyca guyca closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants