React Native v.71 Compliance #4097

asafkorem · 2023-05-31T12:51:14Z

This PR resolves #4066, #4067, #4068, #4069 and #4070.

detox/test/android/build.gradle

docs/introduction/partials/_getting-started-rn.md

error Failed to build the app: No package name found. Found errors in .../android/app/src/main/AndroidManifest.xml.

This reverts commit 4439daf.

asafkorem · 2023-06-13T12:58:03Z

README.md


-### Environment
+Detox was built from the ground up to support React Native projects.
+While Detox should work out of the box with almost any React Native version from the past few minor releases, official support is provided for React Native versions `0.70.x` and `0.71.x` without React Native's ["New Architecture"](https://reactnative.dev/docs/the-new-architecture/landing-page).


@d4vidi regarding your comment - What do you think about:

We officially support Detox for React Native versions 0.70 and 0.71, without the "New Architecture".

TBH I'm not a huge fan of the table since there is really no difference between iOS and Android in terms of our official support. If you want some border that will wrap the version numbers I can make a 1x1 table 😄

…tive

…uct flavors)

d4vidi · 2023-06-29T20:07:28Z

examples/demo-react-native/android/app/build.gradle


 android {
-    compileSdkVersion rootProject.ext.compileSdkVersion
+    namespace 'com.example'
+
    buildToolsVersion rootProject.ext.buildToolsVersion


todo (note to self)

.buildkite/jobs/pipeline.android_demo_app_rn_71.yml

.buildkite/jobs/pipeline.android_rn_71.yml

.buildkite/jobs/pipeline.ios_demo_app_rn_71.yml

.buildkite/jobs/pipeline.ios_rn_71.yml

.buildkite/pipeline.debug.yml

asafkorem · 2023-07-02T16:07:41Z

detox/android/build.gradle

-        maven {
-            url "$projectDir/../../node_modules/react-native/android"
+        mavenCentral()
+        mavenLocal()


let's consider to remove this

detox/android/detox/build.gradle

detox/android/rninfo.gradle

detox/test/android/build.gradle

asafkorem

GG us

detox/test/package.json

docs/contributing.md

docs/introduction/partials/_getting-started-rn.md

examples/demo-react-native/android/build.gradle

examples/demo-react-native/ios/Podfile

examples/demo-react-native/package.json

scripts/ci.android.sh

kevindice · 2023-07-03T16:27:24Z

Thank you! 🎉

RohovDmytro · 2023-07-04T00:31:10Z

Wow! Great & epic.

When 0.72? 😜 I observe that going from 0.71 to 0.72 is doing not bad in the community. Me personally had a great migration experience in a moderately complex project.

asafkorem · 2023-07-04T08:42:02Z

Wow! Great & epic.

When 0.72? 😜 I observe that going from 0.71 to 0.72 is doing not bad in the community. Me personally had a great migration experience in a moderately complex project.

Great question, we may try this soon and if the migration will be seamless we won't postpone it.. Anyhow, Detox might work with 0.72 now without changes. Feel free to try this and update
The new Detox version that officially supports React Native 0.71 is 20.9.1

RohovDmytro · 2023-07-04T09:34:59Z

Wow! Great & epic.
When 0.72? 😜 I observe that going from 0.71 to 0.72 is doing not bad in the community. Me personally had a great migration experience in a moderately complex project.

Great question, we may try this soon and if the migration will be seamless we won't postpone it.. Anyhow, Detox might work with 0.72 now without changes. Feel free to try this and update The new Detox version that officially supports React Native 0.71 is 20.9.1

Sweet.

5 cents:
[email protected] + [email protected] + Android = 👍, worked seamlessly from the first run
[email protected] + [email protected] + iOS = investigating :)

RohovDmytro · 2023-07-04T09:38:02Z

Btw, you guys should know this, but react native 0.71 had a nasty, nasty, awful performance issue (people not screaming enough, but I do).

It had quite severe impact in my bigger project. My performance KPI's plummeted. The app seems okay, but some many skipped frames...

facebook/react-native#35778

It was fixed in 0.72.0 ;) 🙂

d4vidi · 2023-07-04T11:05:17Z

Wow! Great & epic.
When 0.72? 😜 I observe that going from 0.71 to 0.72 is doing not bad in the community. Me personally had a great migration experience in a moderately complex project.

Great question, we may try this soon and if the migration will be seamless we won't postpone it.. Anyhow, Detox might work with 0.72 now without changes. Feel free to try this and update The new Detox version that officially supports React Native 0.71 is 20.9.1

Correction: The official version is 20.10.0 🚀

d4vidi · 2023-07-04T12:55:31Z

@RohovDmytro Thanks for this valuable input. We will definitely take that into account

ruibinch · 2023-09-07T01:59:24Z

@RohovDmytro Hello, just curious if you managed to get this new version of detox working seamlessly with RN 0.72.x on iOS? (will be performing the upgrade soon too)

asafkorem requested review from d4vidi and noomorph as code owners May 31, 2023 12:51

asafkorem marked this pull request as draft May 31, 2023 12:51

This was linked to issues May 31, 2023

[RN 71] iOS compliance: demo projects #4067

Closed

[RN 71] Android compliance: test project #4068

Closed

[RN 71] Android compliance: demo project #4069

Closed

[RN 71] Docs alignment #4070

Closed

[Epic] React Native .71 Compliance #3884

Open

asafkorem mentioned this pull request Jun 6, 2023

[RN 71] iOS compliance: test project #4066

Closed

asafkorem force-pushed the rn-71-support branch from ff45547 to eeb4c7a Compare June 6, 2023 14:02

d4vidi reviewed Jun 8, 2023

View reviewed changes

detox/test/android/build.gradle Show resolved Hide resolved

noomorph reviewed Jun 12, 2023

View reviewed changes

docs/introduction/partials/_getting-started-rn.md Outdated Show resolved Hide resolved

asafkorem added 6 commits June 12, 2023 16:32

ci(pipelines): update tested RN versions to 0.70 and 0.71.

9cbffb6

docs(README): update with RN 0.71 official support.

a52e69f

docs(introduction): update with RN 0.71 official support.

87dc9fa

test(demo): upgrade to support RN 0.71.

65e8b0d

feat: add support for RN 0.71. (WIP)

3d91504

test(test-app): upgrade to support RN 0.71.

0a2b9ff

asafkorem force-pushed the rn-71-support branch from c2d6426 to 0a2b9ff Compare June 12, 2023 13:50

fix(iOS): missing package name on AndroidManifest.xml. (WIP)

5393275

error Failed to build the app: No package name found. Found errors in .../android/app/src/main/AndroidManifest.xml.

asafkorem force-pushed the rn-71-support branch from 81c0d65 to 5393275 Compare June 12, 2023 14:16

asafkorem added 5 commits June 12, 2023 17:49

fix(android): set SDK versions by RN version.

5206974

feat: upgrade RN patch version.

3248cbc

test(demo): revert something on build.gradle. (WIP)

bbc0042

fix(android): try to downgrade sdk versions.

4439daf

Revert "fix(android): try to downgrade sdk versions."

a34a263

This reverts commit 4439daf.

asafkorem commented Jun 13, 2023

View reviewed changes

d4vidi added 3 commits June 14, 2023 16:15

fix(android): Try to fix lookup of unused com.facebook.react:react-na…

17a1f66

…tive

fix(android): Almost fix .aar resolution shitstorm

b8b4cee

Undo most upgrade changes in test project (iOS & Android)

37e3fcf

d4vidi added 8 commits June 27, 2023 16:57

Restart test-proj upgrade from scratch

74a2235

fix(android): Temp-disable some native unit tests

5814b0b

docs: Add warning regarding Android unit tests

1876481

fix(android): [wip] Make lib and test-proj back-compat (rn<71)

a425aea

fix(android): [wip] Make test-proj back-compat (intro. dedicated prod…

fe3bf1d

…uct flavors)

fix(android): Fix issue with back-compat

98f1efb

fix(android): Restore ReactSlider support

39f5fd7

fix(android): Kill demo-project's rn compat, CI-job included

db3287a

d4vidi marked this pull request as ready for review June 29, 2023 12:39

d4vidi added 3 commits June 29, 2023 15:49

General (subtle) clean-ups and adjustments

d2321a7

Undo subtle adjustments that turned out to be breaking

8898465

Undo more subtle adjustments

2fe1cf0

d4vidi reviewed Jun 29, 2023

View reviewed changes

Remove unnecessary todo

fd21005

asafkorem commented Jul 2, 2023

View reviewed changes

Apply suggestions from code review

5a56559

asafkorem commented Jul 3, 2023

View reviewed changes

asafkorem and others added 2 commits July 3, 2023 16:24

Apply suggestions from code review

78b41d9

fix(android): Make prod-flavor (rnDefault/rnLegacy) selection seamless

f39d467

d4vidi approved these changes Jul 3, 2023

View reviewed changes

d4vidi merged commit ce52384 into master Jul 3, 2023

d4vidi deleted the rn-71-support branch July 3, 2023 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React Native v.71 Compliance #4097

React Native v.71 Compliance #4097

asafkorem commented May 31, 2023 •

edited

Loading

asafkorem Jun 13, 2023 •

edited

Loading

d4vidi Jun 29, 2023

asafkorem Jul 2, 2023

asafkorem left a comment

kevindice commented Jul 3, 2023

RohovDmytro commented Jul 4, 2023

asafkorem commented Jul 4, 2023 •

edited

Loading

RohovDmytro commented Jul 4, 2023 •

edited

Loading

RohovDmytro commented Jul 4, 2023 •

edited

Loading

d4vidi commented Jul 4, 2023 •

edited

Loading

d4vidi commented Jul 4, 2023

ruibinch commented Sep 7, 2023

React Native v.71 Compliance #4097

React Native v.71 Compliance #4097

Conversation

asafkorem commented May 31, 2023 • edited Loading

asafkorem Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

d4vidi Jun 29, 2023

Choose a reason for hiding this comment

asafkorem Jul 2, 2023

Choose a reason for hiding this comment

asafkorem left a comment

Choose a reason for hiding this comment

kevindice commented Jul 3, 2023

RohovDmytro commented Jul 4, 2023

asafkorem commented Jul 4, 2023 • edited Loading

RohovDmytro commented Jul 4, 2023 • edited Loading

RohovDmytro commented Jul 4, 2023 • edited Loading

d4vidi commented Jul 4, 2023 • edited Loading

d4vidi commented Jul 4, 2023

ruibinch commented Sep 7, 2023

asafkorem commented May 31, 2023 •

edited

Loading

asafkorem Jun 13, 2023 •

edited

Loading

asafkorem commented Jul 4, 2023 •

edited

Loading

RohovDmytro commented Jul 4, 2023 •

edited

Loading

RohovDmytro commented Jul 4, 2023 •

edited

Loading

d4vidi commented Jul 4, 2023 •

edited

Loading