-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detox core should not read --configuration name from argv directly #338
Comments
This might help indeed, but I guess I will leave this issue open as it can happen for other runner until those are implemented. Will rename issue accordingly. |
Yeah I saw this once, nice job :) |
[email protected] has been released with #335 in it. Should be solved now, right? Can you please verify that the issue is gone now and if so, close the issue? |
Closing this issue, Detox core now reads both argv and env vars (to support Jest) |
I am using Jest just followed Jest guide.
The problem is: jest cli validate the argv arguments.
So you cannot just throw --configuration here.
The thing is: detox rely on argv to read this option so we cannot configure this via node API.
Are you open to a change to make configuration name an option for the node API too? Btw, argv thing should be on CLI, no in the core.
The text was updated successfully, but these errors were encountered: