-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::__1::bad_function_call (crash when using RN >= 0.48) #279
Comments
Does this reproduce consistently? If so, please add an exception breakpoint in Xcode and provide the backtrace of the exception. Thanks. |
Yes, every run this happens. I will post an update soon. Thanks |
hey @pdavid0, can i ask if there anything new? Thanks |
Xcode 9 was released, now fbsimctl is not happy.
An I updated to |
@pdavid0, you can download version 8.3.3 of Xcode using the web instead, and name the current 'Xcode.app' (which is 9 in the case) to for example 'Xcode_9.0.app' and the downloaded version be 'Xcode.app'. Then you can test normally. (This is just the workaround in my case). However, the issue of |
Is this issue fixed with last release 5.8.1? |
Will try tomorrow ! Thanks |
Detox 5.8.1 does not rely on |
5.8.1 has not yet been fixed to support 0.48.X issues. We’ll be investigating soon. |
@LeoNatan, can I ask how about .47? Thanks |
I’m not familiar with any problems there. Try it and let me know. |
@LeoNatan
Node, Device, Xcode and macOS Versions
"react": "16.0.0-alpha.12", |
It works again because when you launch the app using the icon, Detox is not injected in the app. Sorry guys, I have not had time to look into this—working hard on DetoxInstruments. Hopefully, will have some time soon. |
I have the same problem and error. App hangs on black screen or opened and immediately closed. Even if i've clicked on app and open it by my self detox hangs on first spec.
|
I've got the same error as well:
My
|
+1 getting the exact same error
using node v7.10.1 |
In case it helps: tried both iOS 11.0 and 10.3, same results |
+1 Same here
|
Guys, we’re in the process of adding a test suite for modern RN versions (48,49). There currently is no support for these versions on Detox iOS. There’s no more need for examples, I think we have enough of them. Stay tuned... |
@rotemmiz sir, when can we expect this patch? |
@kacgrzes , 5.8.2 is out |
@rotemmiz Is issue resolved? I tried with 5.8.0 and .48.1. But the app is still terminated. Thanks |
Btw, I am not to sure why or how. But just to test what is wrong with RN and Detox, I initialise a whole new simple app with react-native init. And the put the ID to the first screen ever. The app is still showing the message: 'terminated' but the app will still be running and thus the testing example is still executed.
I attached the terminal log here. Hope this could help anything |
@rotemmiz thank you! 🙇 |
We ran into this ourselves too on RN 0.47.1!! We used latest detox, version 5.8.4. I didn't spent much time on it yet, just wanted you to know. Downgrading to detox 5.6.0 solves the issue. But, that was just a quick test. |
Hmm something strange is going on. On latest RN (> 0.48), the new version works, but it may have gotten broken on older versions? |
as I posted in #270 - I get the same. |
There may have been a regression for older RN versions. |
Upgrade your RN. I am not sure it is a priority for us to debug this. If anyone wants to help debug, that would be great. |
Okay. Will try it later today/tomorrow. Updating RN is 99% a pain in the .... :) |
What @simonracz said ;-) Will continue debugging with him today hopefully; so far I managed to create this; RN 0.47.1 & Detox 5.6.0 -> Works with Xcode 8.3.2 -> DOESN’T work with Xcode 9.0.1 So for now we're stuck on Detox 5.6.0 in combination with Xcode 8.3.2 or 5.7.0 in combination with 8.3.3. |
If you guys want to debug at the source level, drop me a line here and I will try to help. |
Ok, we just verified some extra versions. Basically with Xcode 8.3.3 and RN 0.47.1 the following works too; [email protected] Currently pinpointing what difference between [email protected] and [email protected] could make the difference with @simonracz |
It can be reproduced on a fresh new RN project with version 0.47.1. Created via It had dummy views and tests, like in react-native-demo. It crashed the same way. |
Update: Fresh dummy project does NOT work with 0.47.1 and 0.48.0 However, it works with 0.49.0! |
@simonracz @alexcfaber I have just pushed a proposed fix for 0.48. Could you please test? It’s not included in 5.9.3 release. |
What a timing. I just started to work on this again. I’ll test it today. |
The issue was very interesting. My attribute constructor function was causing +initialize to run before the C++ default constructor, which caused their default to override something. |
CI failed though in relaunchApp. |
Hmm. Why would that fail? Are you also seeing it? Could be Travis flakiness. |
It passed for me locally. |
It failed again in CI, on XCode8. I built/ran the local tests with XCode9. |
Yes we saw. Not sure why yet. |
Found the issue. It’s a slight difference of how runloops run in iOS 10 and iOS 11. |
Fixed. @rotemmiz Could you please release a new version? 😙 |
Detox stopped working after upgrading to react-native 0.48.3
Description
App starts then App crash.
<HANGS for 12000 secs>
Node, Device, Xcode and macOS Versions
"react": "^16.0.0-rc.2",
"react-dom": "^16.0.0-rc.2",
"react-native": "0.48.3",
"detox": "^5.6.2",
The text was updated successfully, but these errors were encountered: