Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade min supported RN version to 59 #1181

Closed
d4vidi opened this issue Feb 27, 2019 · 3 comments
Closed

Upgrade min supported RN version to 59 #1181

d4vidi opened this issue Feb 27, 2019 · 3 comments

Comments

@d4vidi
Copy link
Collaborator

d4vidi commented Feb 27, 2019

Description

Android should support .59, even if with an exception remarks due to the RN clipping issue on Android.

Also, the demo apps, which are currently 51 and 56, need latest (i.e. .59) on iOS, android and maybe .57 (RN clipping issue, again - i.e. the full detox test suite, and a partial suite).

@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 13, 2019

WIP in rn58 branch. Android blocker: facebook/react-native#23870

@d4vidi d4vidi changed the title Upgrade RN in detox test and demo apps [Blocked] Upgrade RN in detox test and demo apps Mar 18, 2019
@LeoNatan LeoNatan changed the title [Blocked] Upgrade RN in detox test and demo apps Upgrade RN in detox test and demo apps Mar 25, 2019
@d4vidi d4vidi changed the title Upgrade RN in detox test and demo apps Upgrade min supported RN version to 59 May 5, 2019
@fungilation
Copy link

Quoting @yungsters at facebook/react-native#23870 (comment)

I do not have any good ideas for how to resolve this. I understand the dilemma that this places on Detox, but I do not know how else we could possibly have implemented support for overflow: visible without defaulting setClipChildren(false). Due to the viral nature of overflow, a default of overflow: hidden (and setClipChildren(true)) prevents any meaningful support for overflow: visible which, if you might recall, was one of the top requested features for React Native.

@LeoNatan
Copy link
Contributor

We've introduced a workaround for this and support 0.59.x.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants