Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
asafkorem committed Jun 5, 2023
1 parent 609ed09 commit ff45547
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion detox/test/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ dependencies {

// Apply Hermes as our JS engine
dependencies {
if (rn.rnInfo.isRN71OrHigher) {
if (rnInfo.isRN71OrHigher) {
implementation("com.facebook.react:hermes-android")
} else if (rnInfo.isRN69OrHigher) { // TODO this is actually likely to work with older RN versions as well
implementation('com.facebook.react:hermes-engine:+') {
Expand Down
4 changes: 2 additions & 2 deletions detox/test/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ platform :ios, 13.0
install! 'cocoapods', :deterministic_uuids => false

def shared_pods
config = use_native_modules!
config = use_native_modules!

if !ENV["REACT_NATIVE_VERSION"] || ENV["REACT_NATIVE_VERSION"].match(/0.(68|69|70).*/)
# Flags change depending on the env values.
Expand Down Expand Up @@ -54,7 +54,7 @@ end
post_install do |installer|
__apply_update_deployment_target_workaround(installer)

if ENV["REACT_NATIVE_VERSION"] && ENV["REACT_NATIVE_VERSION"].match(/0.6[6,7,8,9].*/)
if ENV["REACT_NATIVE_VERSION"] && ENV["REACT_NATIVE_VERSION"].match(/0.(66|67|68|69|70|71).*/)
react_native_post_install(installer)
else
react_native_post_install(
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-react-native/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ dependencies {

// Apply Hermes as the JS engine
dependencies {
if (rn.rnInfo.isRN71OrHigher) {
if (rnInfo.isRN71OrHigher) {
implementation("com.facebook.react:hermes-android")
} else if (rnInfo.isRN69OrHigher) { // TODO this is actually likely to work with older RN versions as well
implementation('com.facebook.react:hermes-engine:+') {
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-react-native/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ target 'example' do
post_install do |installer|
__apply_update_deployment_target_workaround(installer)

if ENV["REACT_NATIVE_VERSION"] && ENV["REACT_NATIVE_VERSION"].match(/0.6[6,7,8,9].*/)
if ENV["REACT_NATIVE_VERSION"] && ENV["REACT_NATIVE_VERSION"].match(/0.(66|67|68|69|70|71).*/)
react_native_post_install(installer)
else
react_native_post_install(
Expand Down

0 comments on commit ff45547

Please sign in to comment.