Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule suggestion: detect _.filter(...).each wrong usages #202

Open
Lucas-C opened this issue May 16, 2019 · 0 comments
Open

Rule suggestion: detect _.filter(...).each wrong usages #202

Lucas-C opened this issue May 16, 2019 · 0 comments

Comments

@Lucas-C
Copy link

Lucas-C commented May 16, 2019

Hi.

On an application that was using both lodash & UnderscoreJS (sigh)
I switched to only using lodash.

Then I realized I kept some pieces of code that where using UnderscoreJS ability to chain those operations like this:

_(list).filter(() => true).each(...)

Which became after my erroneous refactoring:

_.filter(list, () => true).each(...)

Do you think it could be possible to detect the use of .each or .forEach on the value returned by lodash _.filter & _.map functions ?

If so I am willing to contribute such rule with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant