Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphic in README.md broken on crates.io #32

Closed
ilyvion opened this issue May 22, 2021 · 3 comments
Closed

Graphic in README.md broken on crates.io #32

ilyvion opened this issue May 22, 2021 · 3 comments

Comments

@ilyvion
Copy link

ilyvion commented May 22, 2021

Graphic in README.md broken on crates.io; see https://crates.io/crates/heck
@jplatte
Copy link
Collaborator

jplatte commented May 26, 2021 •
edited
Loading

I'm a bit surprised it even works in the readme here. I'm not sure what the best fix is, a relative link will probably only work if the image is included in the crate tarball, which it really shouldn't be. An absolute URL to raw.githubusercontent.com is also not right I think, since that domain is specifically not meant for embedding IIRC. I think I've seen some sort of "github user content CDN" before, but don't think it's official.

@jplatte
Copy link
Collaborator

jplatte commented Jun 2, 2021

Actually it might be that relative links are not handled as pointing into the crate tarball on crates.io. It's worth a shot I guess and definitely doesn't hurt to use a relative URL.

@jplatte
Copy link
Collaborator

jplatte commented Jun 2, 2021

Fixed in 0.3.3.

@jplatte jplatte closed this as completed Jun 2, 2021
@jplatte jplatte mentioned this issue Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilyvion @jplatte