Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass an image as part of the evaluation #88

Open
giladgd opened this issue Nov 5, 2023 · 4 comments
Open

feat: pass an image as part of the evaluation #88

giladgd opened this issue Nov 5, 2023 · 4 comments
Assignees
Labels
new feature New feature or request roadmap Part of the roadmap for node-llama-cpp (https://github.com/orgs/withcatai/projects/1)

Comments

@giladgd
Copy link
Contributor

giladgd commented Nov 5, 2023

When llama.cpp's support for this will be stable.
Hopefully, there will be an official API for this after ggerganov/llama.cpp#9643 is implemented.

@giladgd giladgd self-assigned this Nov 5, 2023
@giladgd giladgd converted this from a draft issue Nov 5, 2023
@giladgd giladgd added new feature New feature or request roadmap Part of the roadmap for node-llama-cpp (https://github.com/orgs/withcatai/projects/1) labels Nov 5, 2023
@samlhuillier
Copy link

Interested in this kind of multimodal support. Any update on progress?

@fozziethebeat
Copy link

Does this encompass adding support for running llava models or should that be a separate feature request? I noticed that llama-cpp-python already includes llava support from llama.cpp so this shouldn't be too hard with setting up the bindings.

@giladgd
Copy link
Contributor Author

giladgd commented Dec 3, 2023

I haven't started working on this yet, but it is planned as part of the roadmap.
The plan is to add support for llama.cpp's ability to pass an image to a model, which right now only supports LLaVA.

I'll work on this once llama.cpp's API for this is final, to prevent frequent breaking API changes (unlike what happens on some other libraries)

@fozziethebeat
Copy link

Make sense. Hopefully llama.cpp finalizes that API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request roadmap Part of the roadmap for node-llama-cpp (https://github.com/orgs/withcatai/projects/1)
Projects
Development

No branches or pull requests

3 participants