Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make disabling metal on build work #55

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: make disabling metal on build work #55

merged 1 commit into from
Sep 27, 2023

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Sep 27, 2023

Description of change

fix: make disabling metal on build work

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

@giladgd giladgd self-assigned this Sep 27, 2023
ido-pluto
ido-pluto approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit 03ec18b into master Sep 27, 2023
8 checks passed
@giladgd giladgd deleted the gilad/makeDisablingMetalWork branch September 27, 2023 20:37
@github-actions
Copy link

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @ido-pluto