Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt to llama.cpp interface change #49

Merged
merged 1 commit into from
Sep 23, 2023
Merged

fix: adapt to llama.cpp interface change #49

merged 1 commit into from
Sep 23, 2023

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Sep 23, 2023 •
edited
Loading

Description of change

fix: adapt to llama.cpp interface change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

@giladgd giladgd self-assigned this Sep 23, 2023
@giladgd giladgd changed the title fix: adapt to llama.cpp interface change fix: adapt to llama.cpp interface change Sep 23, 2023
ido-pluto
ido-pluto approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd enabled auto-merge (squash) September 23, 2023 18:05
@giladgd giladgd merged commit 9db72b0 into master Sep 23, 2023
10 checks passed
@giladgd giladgd deleted the gilad/fixLlamaCppInterface branch September 23, 2023 18:11
@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @ido-pluto