Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move default to the last in package.json #31

Merged
merged 1 commit into from
Sep 2, 2023
Merged

fix: move default to the last in package.json #31

merged 1 commit into from
Sep 2, 2023

Conversation

itsuka-dev
Copy link
Contributor

@itsuka-dev itsuka-dev commented Sep 2, 2023

Description of change

This fixes #30

The issue is specific to Next.js (or any project that use Webpack, I think), where default export must be specified last in package.json. The fix simply moves it to the last.

スクリーンショット 2023-09-02 12 44 25

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

Copy link
Contributor

@giladgd giladgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd
Copy link
Contributor

giladgd commented Sep 2, 2023

Thanks @itsuka-dev!

@giladgd giladgd self-assigned this Sep 2, 2023
@giladgd giladgd merged commit dd49959 into withcatai:master Sep 2, 2023
5 checks passed
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not found: Default condition should be last one
2 participants