Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] - Dead link in the Node adapter section #3831

Closed
sasoria opened this issue Jul 26, 2023 · 5 comments
Closed

[CONTENT] - Dead link in the Node adapter section #3831

sasoria opened this issue Jul 26, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Issues looking for someone to run with them! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) low effort

Comments

@sasoria
Copy link
Contributor

sasoria commented Jul 26, 2023

📚 Subject area/topic

Node adapter (@astrojs/node)

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/integrations-guide/node/#troubleshooting

📋 General description or bullet points (if proposing new content)

The Node adapter section links to a known issue that does not exist (it returns 404 on GitHub). I've tried searching for it with no luck. Is the original problem solved by any chance? If we're not sure, then maybe we should just remove the link?

Screenshot

Screenshot 2023-07-26 at 14 01 59

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

@sasoria sasoria added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 26, 2023
@delucis delucis removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jul 27, 2023
@delucis
Copy link
Member

delucis commented Jul 27, 2023

Suggestion from our issue triage:

We can remove the broken link and maybe rephrase “This is a known issue that will be fixed in a future release” to “This is a known issue that may be fixed in a future release” given we don’t currently have an issue tracking this.

(H/T to @lorenzolewis for finding the original issue for reference: https://web.archive.org/web/20221116020927/https://github.com/withastro/astro/issues/4974)

Because this is in one of our integration pages, the change will need making to the README.md file in the Astro repo, rather than directly here in docs.

@delucis delucis added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) good first issue Good for newcomers help wanted Issues looking for someone to run with them! low effort labels Jul 27, 2023
@sdp971
Copy link
Contributor

sdp971 commented Jul 27, 2023

Hi ! Could you assign me this issue please 😊 ?

@sasoria
Copy link
Contributor Author

sasoria commented Jul 28, 2023

Thank you for wanting to pick this up @sdp971 🙌 You can apply the suggested changes here.

@sdp971
Copy link
Contributor

sdp971 commented Jul 28, 2023

Thank you so much @sasoria 🙏

@sarah11918
Copy link
Member

Thank you for making the PR to the Astro repo, @sdp971 ! It was exactly what was needed, so I'm closing this issue! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues looking for someone to run with them! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) low effort
Projects
None yet
Development

No branches or pull requests

4 participants