Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve create-astro startup performance #8456

Merged
merged 5 commits into from
Sep 13, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test by wrapping promise values
natemoo-re committed Sep 13, 2023
commit b20a0dd68fc94f89b9aa873d71ebcbf16bc6281c
4 changes: 2 additions & 2 deletions packages/create-astro/src/actions/intro.ts
Original file line number Diff line number Diff line change
@@ -14,8 +14,8 @@ export async function intro(ctx: Pick<Context, 'hat' | 'skipHouston' | 'version'
'Welcome',
'to',
label('astro', color.bgGreen, color.black),
ctx.version.then(version => ((version ? color.green(`v${version}`) : '') + ',')),
ctx.username.then(username => `${username}!`),
Promise.resolve(ctx.version).then(version => ((version ? color.green(`v${version}`) : '') + ',')),
Promise.resolve(ctx.username).then(username => `${username}!`),
],
random(welcome),
],