Fix #6618: sitemap urls generated without slash

[andremralves]

Changes

closes #6618

I added a condition to check whether the base path has a trailing slash or not (when the base path and page path are concatenated) and add the trailing slash if it's missing.

I tested using the @example/blog with this configuration:

export default defineConfig({
	site: 'https://example.com',
	integrations: [mdx(), sitemap()],
	base: '/base',
	trailingSlash: 'never',
});

Before:

• sitemap-index.xml

<?xml version="1.0" encoding="UTF-8"?><sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"><sitemap><loc>https://example.com/sitemap-0.xml</loc></sitemap></sitemapindex>

• sitemap-0.xml

<?xml version="1.0" encoding="UTF-8"?><urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:news="http://www.google.com/schemas/sitemap-news/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1" xmlns:video="http://www.google.com/schemas/sitemap-video/1.1"><url><loc>https://example.com/base</loc></url><url><loc>https://example.com/baseabout</loc></url><url><loc>https://example.com/baseblog</loc></url><url><loc>https://example.com/baseblog/first-post</loc></url><url><loc>https://example.com/baseblog/markdown-style-guide</loc></url><url><loc>https://example.com/baseblog/second-post</loc></url><url><loc>https://example.com/baseblog/third-post</loc></url><url><loc>https://example.com/baseblog/using-mdx</loc></url></urlset>

After:

• sitemap-index.xml

<?xml version="1.0" encoding="UTF-8"?><sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"><sitemap><loc>https://example.com/base/sitemap-0.xml</loc></sitemap></sitemapindex>

• sitemap-0.xml

<?xml version="1.0" encoding="UTF-8"?><urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:news="http://www.google.com/schemas/sitemap-news/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1" xmlns:video="http://www.google.com/schemas/sitemap-video/1.1"><url><loc>https://example.com/base</loc></url><url><loc>https://example.com/base/about</loc></url><url><loc>https://example.com/base/blog</loc></url><url><loc>https://example.com/base/blog/first-post</loc></url><url><loc>https://example.com/base/blog/markdown-style-guide</loc></url><url><loc>https://example.com/base/blog/second-post</loc></url><url><loc>https://example.com/base/blog/third-post</loc></url><url><loc>https://example.com/base/blog/using-mdx</loc></url></urlset>

Testing

I added two new tests for cases were you have a base URL.

• One to test base URL + trailingSlash: never
• And the other to test base URL + trailingSlash: always

Docs

No docs needed, just a bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 03039b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

One tiny nit, but this looks great! Nice tests.

[43081j]

If we can depend on the node stdlib here, could we just use path.join rather than concatenating strings manually?

[andremralves]

@43081j I thought about it, but I didn't see they using path.join anywhere in the code base and I would change some code that was already done, so I decided to just use simple concatenation in this case.

[bluwy]

Thanks!