Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better behavior for 'undefined' return values from 'serialize… #3723

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

alextim
Copy link
Contributor

@alextim alextim commented Jun 27, 2022

Changes

If serialize function returns undefined value for the passed entry, such entry will be excluded from sitemap

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: cfa48c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/sitemap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 27, 2022
@matthewp
Copy link
Contributor

Please add a changeset with pnpm changeset. Thanks!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a ton of sense, thanks for the update!

@alextim
Copy link
Contributor Author

alextim commented Jun 27, 2022

I've my astro-sitemap as pet project.
If it runs smoothly I'll transfer the rest of its features to the official one by one.

@natemoo-re natemoo-re merged commit 52f7536 into withastro:main Jun 27, 2022
@astrobot-houston astrobot-houston mentioned this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants