Adds an error message for non-string transition:name values #10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f10715 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
No, we don't have a logger in the runtime. I think it's fair to throw an error, a user might not see the log. |
ematipico
approved these changes
Feb 23, 2024
matthewp
approved these changes
Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #10150
I think throwing an error is pretty brutal but at least it shows up during
astro dev.Is there a way to access a logger here?
I'm unsure whether we really need the check this way:
[ - ] IDE integrations and
astro checkwarn correctly, (but we can't force everybody to use them).[ + ]
astro devandastro builddon't give any error message so far, see issue mentioned above.Testing
Manual test
Docs
n.a. bugfix