Setting mode: "production" in programmatic build() doesn’t set NODE_ENV

[KonnorRogers]

What version of starlight are you using?

0.15.0

What version of astro are you using?

4.0.6

What package manager are you using?

npm

What operating system are you using?

mac

What browser are you using?

Firefox

Describe the Bug

When using programmatic JS APIs, setting mode: "production", still requires setting: process.env.NODE_ENV = "production" to enable pagefind.

Example:

   import { build } from "astro"
   // Pagefind doesn't work
    await build({
      ...config,
      mode: "production"
    })
   
    // Enables pagefind
    process.env.NODE_ENV = "production"
    await build({
      ...config,
      mode: "production"
    })

I'm not sure if this is expected behavior, or if its a bug.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-a6bay1?file=README.md

Participation

• I am willing to submit a pull request for this issue.

[HiDeoo]

Thanks for your report 🙌

From a quick test, it looks like Pagefind is running at the end of the build as expected although the search feature is definitely not accessible.

This is due to this check and this one relying on import.meta.env.DEV which would be set to true with the following code:

import { build } from 'astro';

await build({
	root: './',
	// Setting `mode` will not change the value of `import.meta.env.DEV`
});

We could easily switch to import.meta.env.MODE === 'development' which should fix the issue altho I wonder if the API behaves in the way we expect it to? When running astro build, import.meta.env.DEV is false without explicitly setting anything so I guess the same could be expected when running the API version considering the docs states:

Similar to astro build

[KonnorRogers]

@HiDeoo yea I found the Search.astro component and was mostly looking for clarification if this is intended behavior or not. But it is interested it seems to set the ENV properly with astro build, but not the programmatic API. It's small, easily fixed, was mostly just looking for clarification

[delucis]

Thanks for the issue @KonnorRogers! I think this is a bug in the JS API not setting the same environment as its CLI equivalent. Let me check with the astro team to see if they’d intend to fix it — if not we can patch it here as @HiDeoo suggested.

[delucis]

Chatted with @bluwy and confirmed we can fix this upstream in the main Astro repo. Thanks again for reporting @KonnorRogers!

[KonnorRogers]

❤️ thank you all! Astro rocks 🤘