Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Picture /> ignoring src's IFD0:Orientation metadata #7442

Closed
1 task
auroraanna opened this issue Jun 21, 2023 · 3 comments · Fixed by #7510
Closed
1 task

<Picture /> ignoring src's IFD0:Orientation metadata #7442

auroraanna opened this issue Jun 21, 2023 · 3 comments · Fixed by #7510
Labels
pkg: image Related to the `@astrojs/image` package (scope)

Comments

@auroraanna
Copy link

What version of astro are you using?

2.5.6

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

yarn

What operating system are you using?

Linux

What browser are you using?

Brave (Chromium)

Describe the Bug

The element is ignoring the IFD0:Orientation image metadata of the src attribute which results in falsely rotated images and a stretched image.

Example

The following image with width 2998, height 3998 and orientation 90 degrees clockwise as displayed by gThumb:
image

The result of passing it through Astro's <Picture> element:
image

What's the expected result?

The image metadata orientation should be taken into account.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-m6jojv

Participation

  • I am willing to submit a pull request for this issue.
@natemoo-re natemoo-re added the pkg: image Related to the `@astrojs/image` package (scope) label Jun 21, 2023
@natemoo-re
Copy link
Member

Thanks for opening an issue! We are focusing our efforts on the built-in assets support rather than @astrojs/image bugs, but we'd be happy to review a PR that fixes this!

@Mrowa96
Copy link
Contributor

Mrowa96 commented Jun 28, 2023

@natemoo-re I created PR to fix the issue, can I ask you for CR?

@natemoo-re
Copy link
Member

Yep, taking a look now. Thanks so much @Mrowa96!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: image Related to the `@astrojs/image` package (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants