Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically creating a top level root page does not work with build format 'file' #5121

Closed
1 task done
christian-hackyourshack opened this issue Oct 19, 2022 · 1 comment · Fixed by #5123
Closed
1 task done
Assignees
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@christian-hackyourshack
Copy link
Contributor

What version of astro are you using?

1.5.1

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

I am trying to create a top-level root page dynamically according to the docs (https://docs.astro.build/en/core-concepts/routing/#example-dynamically-create-a-top-level-root-page) it works fine for the default build format directory, but when switching to build format 'file', the index.html is generated into the top-level project-directory instead of dist.

If someone points me to the place, where the file path is derived from the URL, then I could submit a pull request for this.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-9r4avl?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp added the - P4: important Violate documented behavior or significantly impacts performance (priority) label Oct 19, 2022
@matthewp
Copy link
Contributor

Sorry about that, I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants