Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server island not work when using preload library #12421

Closed
1 task
futamiy opened this issue Nov 12, 2024 · 6 comments · Fixed by #12444
Closed
1 task

Server island not work when using preload library #12421

futamiy opened this issue Nov 12, 2024 · 6 comments · Fixed by #12444
Assignees
Labels
- P2: nice to have Not breaking anything but nice to have (priority) feat: server islands Related to Server Islands (scope)

Comments

@futamiy
Copy link

futamiy commented Nov 12, 2024

Astro Info

Astro                    v4.16.10
Node                     v22.11.0
System                   Windows (x64)
Package Manager          npm
Output                   hybrid
Adapter                  @astrojs/cloudflare
Integrations             @astrojs/tailwind
                         @astrojs/svelte

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When in page with server island and open link with server island (and same name component too) where using preload library like framethrower, component not loaded and show this error
CopyQ eBdChL
CopyQ bObKnR

Repo

What's the expected result?

server island component load normally even use preload library

Link to Minimal Reproducible Example

Web Preview: https://4885e27d.futami.pages.dev/
Stackblitz Link: https://stackblitz.com/edit/withastro-astro-tkdvnm?file=package.json

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Nov 12, 2024
@apatel369
Copy link
Contributor

@futamiy Please provide a valid reproduction. Here is the guide to create it.

@florian-lefebvre florian-lefebvre added the needs repro Issue needs a reproduction label Nov 13, 2024
Copy link
Contributor

Hello @futamiy. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Nov 13, 2024
@futamiy
Copy link
Author

futamiy commented Nov 13, 2024

@ematipico ematipico added the needs triage Issue needs to be triaged label Nov 13, 2024
@ematipico
Copy link
Member

What does flamethrower do? Without the library, the server island works, so @futamiy you would need to explain to us at least what's happening.

@ematipico ematipico removed the needs repro Issue needs a reproduction label Nov 13, 2024
@futamiy
Copy link
Author

futamiy commented Nov 13, 2024

Video reproduce

Content.1113.mp4

Error code
CopyQ HGUnfH

When click a link and using flamethrower, image can't show until refreshed manually because replacing body from library
Explain framethrower video: https://youtu.be/SJeBRW1QQMA?t=311

@ematipico
Copy link
Member

I don't think there's much we can do, if a library messes up with script tags, we can't prevent it.

I will send a PR to avoid that runtime error in the console, but maybe you should check if that library allows to prevent prefetching all script tags

@ematipico ematipico added - P2: nice to have Not breaking anything but nice to have (priority) feat: server islands Related to Server Islands (scope) and removed needs triage Issue needs to be triaged labels Nov 15, 2024
@ematipico ematipico self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) feat: server islands Related to Server Islands (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants