Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node v21, add node v22? (minor) #11382

Closed
mrienstra opened this issue Jun 30, 2024 · 2 comments
Closed

Drop node v21, add node v22? (minor) #11382

mrienstra opened this issue Jun 30, 2024 · 2 comments
Labels
needs triage Issue needs to be triaged

Comments

@mrienstra
Copy link
Contributor

mrienstra commented Jun 30, 2024

The engines fields in the various* package.json files currently have:

  "engines": {
    "node": "^18.17.1 || ^20.3.0 || >=21.0.0"
  },

As per https://nodejs.org/en/about/previous-releases#release-schedule, seems like it's about time to replace v21 with v22?

Oh, hmm, reading https://docs.astro.build/en/upgrade-astro/#support, kinda seems like v22 won't be added until it is the current LTS (scheduled for November-ish), is that right?

Very minor, not particularly high priority, just thought I'd call it out.

Related PR: #10689 (bumped v18.14.1 to v18.20.1)


*: There are 13 package.json files, they all have the same "node" field, but packages/astro/package.json also adds ranges for npm & pnpm:

  "engines": {
    "node": "^18.17.1 || ^20.3.0 || >=21.0.0",
    "npm": ">=9.6.5",
    "pnpm": ">=7.1.0"
  },
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jun 30, 2024
@mrienstra mrienstra changed the title (chore): drop node v21, add node v22? (minor) Drop node v21, add node v22? (minor) Jun 30, 2024
@ematipico
Copy link
Member

As you said, we won't add v22 until it goes in LTS. What's the issue for?

@mrienstra
Copy link
Contributor Author

Fair enough, it just seemed odd at first glance to have an odd release this close to v22 going LTS, but yeah, makes sense to wait, and in the meantime, no reason to rush to drop support for v21.

@mrienstra mrienstra closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants