Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astro:assets noop does not work on Cloudflare Runtime #54

Closed
alexanderniebuhr opened this issue Nov 8, 2023 · 0 comments · Fixed by withastro/astro#9029
Closed

astro:assets noop does not work on Cloudflare Runtime #54

alexanderniebuhr opened this issue Nov 8, 2023 · 0 comments · Fixed by withastro/astro#9029
Assignees
@alexanderniebuhr
Labels
- P4: important Violate documented behavior or significantly improves performance (priority) bug Something isn't working feat: assets Related to the Assets feature (scope) pkg: cloudflare

Comments

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 8, 2023 •
edited
Loading

We need a custom endpoint, due to Buffer.from which is not support on Cloudflare Runtime. We will use the generic endpoint from core, without Node Buffer

https://canary.discord.com/channels/830184174198718474/845430950191038464/1171883769410621522
https://canary.discord.com/channels/830184174198718474/1171625875901534258
@alexanderniebuhr alexanderniebuhr self-assigned this Nov 8, 2023
@alexanderniebuhr alexanderniebuhr added bug Something isn't working pkg: cloudflare - P4: important Violate documented behavior or significantly improves performance (priority) feat: assets Related to the Assets feature (scope) labels Nov 8, 2023
@Princesseuh Princesseuh mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderniebuhr alexanderniebuhr

Labels
- P4: important Violate documented behavior or significantly improves performance (priority) bug Something isn't working feat: assets Related to the Assets feature (scope) pkg: cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(assets): Use uint8arrays instead of Buffer in code that can run outside of Node withastro/astro
1 participant
@alexanderniebuhr