Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing $string['privacy:metadata'] #61

Closed
christina-roperto opened this issue Sep 20, 2021 · 1 comment · Fixed by #63
Closed

missing $string['privacy:metadata'] #61

christina-roperto opened this issue Sep 20, 2021 · 1 comment · Fixed by #63
Labels
state:accepted We'll work on this issue soon type:bug Something isn't working

Comments

@christina-roperto
Copy link

Got this message below when I ran vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

1) provider_testcase::test_null_provider with data set "tinymce_tiny_mce_wiris" ('tinymce_tiny_mce_wiris', 'tinymce_tiny_mce_wiris\privac...ovider')
Expectation failed, debugging() was triggered.
Debugging: Invalid get_string() identifier: 'privacy:metadata' or component 'tinymce_tiny_mce_wiris'. Perhaps you are missing $string['privacy:metadata'] = ''; in /siteroot/lib/editor/tinymce/plugins/tiny_mce_wiris/lang/en/tinymce_tiny_mce_wiris.php?
* line 353 of /lib/classes/string_manager_standard.php: call to debugging()
* line 7410 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
* line 90 of /privacy/tests/provider_test.php: call to get_string()
* line 1154 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to provider_testcase->test_null_provider()
* line 842 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
* line 80 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
* line 693 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
* line 796 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
* line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
* line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 652 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
* line 206 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->doRun()
* line 162 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
* line 61 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()

Failed asserting that 1 matches expected 0.

/siteroot/lib/phpunit/classes/advanced_testcase.php:367
/siteroot/privacy/tests/provider_test.php:91
/siteroot/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

Will send PR soon.

@icaparros-at-wiris icaparros-at-wiris added state:accepted We'll work on this issue soon type:bug Something isn't working labels Oct 6, 2021
@icaparros-at-wiris icaparros-at-wiris linked a pull request Oct 6, 2021 that will close this issue
@dcanet-at-wiris dcanet-at-wiris linked a pull request Oct 7, 2021 that will close this issue
@icaparros-at-wiris
Copy link
Contributor

Hello @christina-roperto,

Thank you for reporting the error.

We have fixed it in a new pull request (#63) using the code that you provided and an update to the Changelog file.

Changes are now available on the main branch if you want to use them, while a new release will be planned on the next weeks.

We will close your pull request while leaving the issue open until we don’t release it officially to Moodle.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:accepted We'll work on this issue soon type:bug Something isn't working
Projects
None yet
2 participants