-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-ui: Fix X9Developers/block-explorer#55 by upgrading dependencies #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments / questions, also, i wonder if you tested the whether the UI flows work as expected.
Thanks.
Everything looks good to me, I'll test the app with your changes before merging the PR, thanks! |
@esuau I tried running the project and there are some issues, I can remember that the main view doesn't display the latest blocks, nor, the address view seems to work. From the main view, I see this on the developer console, could you please try to fix the issues?
|
Looks like it works, thanks! |
Problem
Resolve GitHub vulnerability warning related to angular
Running
npm audit
found 54 vulnerability issues related to dependencies, mostly caused by the use of outdated versions.Solution
I ran
npm audit fix
andnpm audit fix --force
to fix the vulnerabilities, which forced me to upgrade to the latest version of Angular following the Angular Update Guide. I also had to upgrade all other dependencies related to Angular (6). I installedrxjs-compat
to keep the application compatible with RxJS 6. I addedmoment
to dependencies, as requested by the new version ofngx-moment
. Finally, I adapted the path toNgHttpLoaderModule
inapp.module.ts
corresponding to the new version ofng-http-loader
.