Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless calls to xsnd #48

Open
AlexITC opened this issue Sep 8, 2018 · 0 comments
Open

Remove useless calls to xsnd #48

AlexITC opened this issue Sep 8, 2018 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest server Changes required on the server project

Comments

@AlexITC
Copy link
Collaborator

AlexITC commented Sep 8, 2018

There are some unnecessary calls on the XSNService.

Expected behavior

There shouldn't be unnecessary calls.

Actual behavior

After the segwit integration, the addressindex was removed, leading to some useless calls on the XSNService, remove them:

def getAddressBalance(address: Address): FutureApplicationResult[rpc.AddressBalance]

def getTransactions(address: Address): FutureApplicationResult[List[TransactionId]]
@AlexITC AlexITC added the good first issue Good for newcomers label Sep 8, 2018
@AlexITC AlexITC added Hacktoberfest server Changes required on the server project labels Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest server Changes required on the server project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexITC