Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pipe for rendering the currency values #43

Closed
AlexITC opened this issue Jul 30, 2018 · 1 comment
Closed

Create a pipe for rendering the currency values #43

AlexITC opened this issue Jul 30, 2018 · 1 comment
Labels
good first issue Good for newcomers web-ui Changes required on the web-ui project

Comments

@AlexITC
Copy link
Collaborator

AlexITC commented Jul 30, 2018

Create the explorerCurrency pipe that takes a number and renders it our currency symbol

Expected behavior

It should be possible to render amounts with this: {{item.value | explorerCurrency}}

Ideally, the currency symbol will be taken from a configuration file.

Actual behavior

We use the following approach to render the explorer amounts: {{item.value}} {{'label.coinName' | translate}}

This has several drawbacks like requiring to repeat the translation key on every language.

@AlexITC
Copy link
Collaborator Author

AlexITC commented Oct 1, 2018

This is very similar to the work done on #42

@AlexITC AlexITC added web-ui Changes required on the web-ui project and removed enhancement labels Oct 6, 2018
JonSalazar added a commit to JonSalazar/block-explorer that referenced this issue Jan 11, 2019
Add pipe class and change all the occurrences to use it instead of label.coinName
@AlexITC AlexITC closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers web-ui Changes required on the web-ui project
Projects
None yet
Development

No branches or pull requests

1 participant