Missed featureFlags options for services-demo in docker config

[mimikadze]

According to #882 (comment) reply there is a missed featureFlags options for services-demo in docker config. Which leads to

galley: user error (AesonException "Error in $.settings: When parsing the record Settings of type Galley.Options.Settings the key featureFlags was not present.")
servicesdemo_galley_1 exited with code 1

on $ deploy/services-demo/demo.sh docker

Adding

featureFlags:
    sso: disabled-by-default
    legalhold: disabled-by-default

to deploy/services-demo/conf/galley.demo-docker.yaml fixed the issue on my machine.

[mimikadze]

Next I faced the same problem in brig module.

$ deploy/services-demo/demo.sh docker
re-using existing TURN secret
re-using existing public/private keys
make: Entering directory '/home/staging/wire-server/services/nginz'
make: 'zwagger-ui/swagger-ui' is up to date.
make: Leaving directory '/home/staging/wire-server/services/nginz'
Starting servicesdemo_gundeck_1 ...
Starting servicesdemo_spar_1 ...
Starting servicesdemo_spar_1
Starting servicesdemo_cannon_1 ...
Starting servicesdemo_gundeck_1
Starting servicesdemo_galley_1 ...
Starting servicesdemo_proxy_1 ...
Starting servicesdemo_cannon_1
Starting servicesdemo_proxy_1
Starting servicesdemo_galley_1
Starting servicesdemo_cargohold_1 ...
Starting servicesdemo_galley_1 ... done
Starting servicesdemo_brig_1 ...
Starting servicesdemo_brig_1 ... done
Starting servicesdemo_nginz_1 ...
Starting servicesdemo_nginz_1 ... done
Attaching to servicesdemo_proxy_1, servicesdemo_cargohold_1, servicesdemo_cannon_1, servicesdemo_gundeck_1, servicesdemo_spar_1, servicesdemo_galley_1, servicesdemo_brig_1, servicesdemo_nginz_1
proxy_1      | I, Listening on 127.0.0.1:8087
cargohold_1  | I, Listening on cargohold:8084
gundeck_1    | I, logger=cassandra.gundeck, Known hosts: [datacenter1:rack1:172.18.0.8:9042]
gundeck_1    | I, logger=cassandra.gundeck, New control connection: datacenter1:rack1:172.18.0.8:9042#<socket: 11>
cannon_1     | I, Listening on cannon:8083
gundeck_1    | I, Listening on gundeck:8086
spar_1       | D, logger=cassandra.spar, Connecting to 172.18.0.8:9042
spar_1       | I, logger=cassandra.spar, Known hosts: [datacenter1:rack1:172.18.0.8:9042]
spar_1       | I, logger=cassandra.spar, New control connection: datacenter1:rack1:172.18.0.8:9042#<socket: 11>
galley_1     | I, logger=cassandra.galley, Known hosts: [datacenter1:rack1:172.18.0.8:9042]
spar_1       | D, logger=cassandra.spar, Connection established: datacenter1:rack1:172.18.0.8:9042#<socket: 12>
galley_1     | I, logger=cassandra.galley, New control connection: datacenter1:rack1:172.18.0.8:9042#<socket: 11>
spar_1       | I, Listening on spar:8088
brig_1       | brig: user error (AesonException "Error in $.zauth.authSettings: key \"legalHoldUserTokenTimeout\" not found")
galley_1     | I, Listening on galley:8085
nginz_1      | 2020/04/30 09:24:52 [emerg] 1#0: host not found in upstream "brig:8082" in /configs/conf/nginz/upstreams-docker:29
nginz_1      | nginx: [emerg] host not found in upstream "brig:8082" in /configs/conf/nginz/upstreams-docker:29
servicesdemo_brig_1 exited with code 1
servicesdemo_nginz_1 exited with code 1

And fixed issue the same way: added missed keys

    legalHoldUserTokenTimeout: 4838400    # 56 days
    legalHoldSessionTokenTimeout: 604800  # 7 days
    legalHoldAccessTokenTimeout: 900 # 15 minutes

to deploy/services-demo/conf/brig.demo-docker.yaml

I consider this issues close coupled, and not opening second one. Hope, this helps.