Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clone() cloning prototype's custom methods for 2.x #1086

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix: clone() cloning prototype's custom methods for 2.x #1086

merged 1 commit into from
Apr 19, 2018

Conversation

jettcalleja
Copy link

Hi @indexzero

I created this pull request for the version 2.x references to my old pull request #1078

fix: clone method in common.js should not clone the prototype custom methods for 2.x version

var a = [1,2];
Array.prototype.try = function() {return true;};
winston.info(a);  // info:  0=1, 1=2, try=function () {return true;}

@indexzero
Copy link
Member

Seems reasonable. Could you also open this PR against winston-compat?

@jettcalleja jettcalleja mentioned this pull request Oct 5, 2017
Merged
@jettcalleja
Copy link
Author

Sure @indexzero, this is the link of the PR: winston-compat/1

@indexzero indexzero merged commit 19d1cdb into winstonjs:2.x Apr 19, 2018
cjbarth pushed a commit to cjbarth/winston that referenced this pull request Aug 22, 2018
Merge commit 'dc74db60b8d46475fce04bab1e0c31abe5201e09' into prd-build
8c6235d 
* commit 'dc74db60b8d46475fce04bab1e0c31abe5201e09': (34 commits)
  [dist] Maintenance release. 2.4.3
  [Winston 2.x] Decycle circular `Error` instances (winstonjs#1307)
  [dist] Maintenance release. 2.4.2
  [dist] Add .gitattributes file.
  [fix] Backport winstonjs#1281 onto 2.x for maintenance.
  [dist] Add ignores from 3.x for easier maintenance switching.
  fix: clone() cloning prototype's custom methods (winstonjs#1086)
  Don't swallow Error message/stack when using formatter (winstonjs#1188)
  [dist] Add package-lock.json
  Update http.js - Add support for headers
  fix 2.x readme (fixes winstonjs#1179)
  [dist] Maintenance release. 2.4.1
  Always pass a function to fs.close (winstonjs#1227)
  Update documentation for the `stringify` option
  [dist] Version bump. 2.4.0
  [fix] Correct documentation mistake in 2.x
  Add how to colorize output in the custom formatter example (winstonjs#989)
  [fix] Container.add() 'filters' and 'rewriters' option passing to logger (winstonjs#1036)
  Fixed working of "humanReadableUnhandledException" parameter when additional data is added in meta (winstonjs#1066)
  Added filtering by log level (winstonjs#1040)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexzero indexzero indexzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jettcalleja @indexzero