Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename recognize to take for consistency #570

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Jul 22, 2024

We can consider other names, like capture, in the future but for now, let's be consistent.

Fixes #488

@epage epage enabled auto-merge July 22, 2024 17:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10045919718

Details

  • 5 of 16 (31.25%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 42.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/parser.rs 2 4 50.0%
src/parser.rs 0 4 0.0%
src/ascii/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
src/token/mod.rs 1 75.0%
Totals Coverage Status
Change from base Build 10045722843: -0.03%
Covered Lines: 1311
Relevant Lines: 3113

💛 - Coveralls

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.11%. Comparing base (64cbabf) to head (db5030f).

Files Patch % Lines
src/ascii/mod.rs 37.50% 5 Missing ⚠️
src/parser.rs 0.00% 4 Missing ⚠️
src/combinator/parser.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   42.14%   42.11%   -0.03%     
==========================================
  Files          18       18              
  Lines        3111     3113       +2     
==========================================
  Hits         1311     1311              
- Misses       1800     1802       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epage epage merged commit ed59acf into winnow-rs:main Jul 22, 2024
15 of 17 checks passed
@epage epage deleted the take branch July 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"recognize" meaning is non-obvious
2 participants