fix(client): set correct parent of output configuration

Setting the manager as parent of a configuration is unexpected and unsafe. Instead set the provided parent if any.
winft · Apr 8, 2023 · ac23f41 · ac23f41
1 parent 558a5ea
commit ac23f41
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/client/wlr_output_manager_v1.cpp b/src/client/wlr_output_manager_v1.cpp
@@ -150,8 +150,7 @@ bool WlrOutputManagerV1::isValid() const
 
 WlrOutputConfigurationV1* WlrOutputManagerV1::createConfiguration(QObject* parent)
 {
-    Q_UNUSED(parent);
-    auto* config = new WlrOutputConfigurationV1(this);
+    auto config = new WlrOutputConfigurationV1(parent);
     auto w = zwlr_output_manager_v1_create_configuration(d->outputManager, d->serial);
 
     if (d->queue) {