Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hint for python module. #58

Closed
baseplate-admin opened this issue Dec 24, 2021 · 0 comments
Closed

Add type hint for python module. #58

baseplate-admin opened this issue Dec 24, 2021 · 0 comments

Comments

@baseplate-admin
Copy link

baseplate-admin commented Dec 24, 2021

Hi there, Sorry for pinging you in Christmas. ( Merry Christmas ). I hope you are having a good day.

I am using your awesome library minify-html for my module

While working on this i had to refer to the underlying rust module several times to get all the options.

Now I think it would be better to add type hint to the module to make it a bit developer friendly. As discussed here it should be very easy to add type hint to PyO3. I already forked this project and added the .pyi file according to this dummy repo from maturin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants