Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Python code using Black #55

Closed
za opened this issue Jul 26, 2023 · 4 comments
Closed

Format Python code using Black #55

za opened this issue Jul 26, 2023 · 4 comments

Comments

@za
Copy link
Contributor

za commented Jul 26, 2023

Hi there,

Do you mind formatting the Python source code using Black? I know it's opinionated, but IMHO having a standardized format will make the code easier to read.

I can prepare the PR and we may check the diff.

@williballenthin
Copy link
Owner

hi @za

in #38 we mention a goal of using Black to format the code, along with isort and a few other linters. so, yes, this is on the roadmap.

however, i don't want to do a one-time formatting; instead, we'll want to configure CI to check the formatting on each push and release etc. i think we'll use the pre-commit tool and github actions for this.

@ajnelson-nist and @sldouglas-nist have been working on many code quality updates recently, so i'd like to give them a chance to do this, if they'd like (no pressure). otherwise, we can coordinate here about how to apply Black to this project.

@williballenthin
Copy link
Owner

i'll leave this issue open as the central point of discussion for configuring Black to run during CI and beyond, ideally with pre-commit.

@ajnelson-nist
Copy link
Contributor

PR #57 has been opened to address this Issue.

@williballenthin
Copy link
Owner

closed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants