Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in BarSeries & DensitySeries when displaying object arrays #156

Open
runako opened this issue Dec 17, 2018 · 1 comment
Open

Warning in BarSeries & DensitySeries when displaying object arrays #156

runako opened this issue Dec 17, 2018 · 1 comment
Labels

Comments

@runako
Copy link

runako commented Dec 17, 2018

Thanks for your hard work on this component! It looks great and has proven super useful for my project.

I'm displaying a histogram using a BarSeries and a DensitySeries, based on the example:

https://williaster.github.io/data-ui/?selectedKind=histogram&selectedStory=normal&full=0&addons=0&stories=1&panelRight=0

The data I pass to the rawData prop of each component is an array of objects, and I'm using the valueAccessor property on the histogram component to specify how to get the data for rendering. This works great, but it causes warnings to be generated in the the console log:

Warning: Failed prop type: Invalid prop rawData[0] supplied to DensitySeries.

In summary, the functionality works great but the warnings in the console are suboptimal.

@williaster
Copy link
Owner

Thanks for checking out @data-ui @runako and raising this issue 🐛 I should be able to fix this and get a release out in the next day or two. Will ping you here when it's out 👍

@williaster williaster added the bug label Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants