Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cmd from upstream lspconfig to start psalm #477

Merged
merged 2 commits into from
Oct 22, 2024
Merged

use cmd from upstream lspconfig to start psalm #477

merged 2 commits into from
Oct 22, 2024

Conversation

rhjdvsgsgks
Copy link
Contributor

use psalm --language-server instead of psalm-language-server. otherwise it will break psalm installed from system package manager, which have only psalm phar.

please test will it break psalm installed from mason (using composer)

@rhjdvsgsgks rhjdvsgsgks marked this pull request as draft October 20, 2024 16:59
@rhjdvsgsgks rhjdvsgsgks marked this pull request as ready for review October 20, 2024 17:02
williamboman
williamboman approved these changes Oct 22, 2024
View reviewed changes
Copy link
Owner

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@williamboman

This comment has been minimized.

Sign in to view
@williamboman williamboman merged commit 7446f47 into williamboman:main Oct 22, 2024
12 checks passed
@williambotman williambotman mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamboman williamboman williamboman approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhjdvsgsgks @williamboman @williambotman