Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Add support for the new Cairo language server #453

Open
LeJamon opened this issue Aug 18, 2024 · 0 comments
Open

Update/Add support for the new Cairo language server #453

LeJamon opened this issue Aug 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@LeJamon
Copy link

LeJamon commented Aug 18, 2024

Is your feature request related to a problem? Please describe.

The current Cairo LSP supported by mason-lspconfig has been archived (it only supports Cairo 1.0) and is no longer maintained: https://github.com/ericglau/cairo-ls

Problem

The Cairo ecosystem has evolved, and the language server is now included in Scarb, the package manager for Cairo projects. This new language server needs to be supported in mason-lspconfig.

Describe the solution you'd like

  1. Rename the current Cairo LSP to cairo_1_ls to maintain backward compatibility for Cairo 1.0 projects.
  2. Add support for the new Cairo language server that's bundled with Scarb.

Implementation Suggestion

Since the language server is now part of Scarb, and Scarb is required to run Cairo projects, we could:

  1. Add a script that fetches the language server directly from Scarb.
  2. Implement a similar logic to what's done in the Cairo VSCode extension for detecting and using the Scarb-bundled language server.

Benefits

  • Ensures up-to-date language server support for the latest Cairo versions.
  • Maintains compatibility with older Cairo 1.0 projects.
  • Aligns with the current Cairo ecosystem tooling.

Describe potential alternatives you've considered

No response

Additional context

@LeJamon LeJamon added the enhancement New feature or request label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant